Skip to content

Fixes #2383 #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fixes #2383 #2419

wants to merge 4 commits into from

Conversation

Ankush263
Copy link
Contributor

@Ankush263 Ankush263 commented Sep 11, 2023

Fixes #2383

Changes:

I have verified that this pull request:

  • [✅] has no linting errors (npm run lint)
  • [✅] has no test errors (npm run test)
  • [✅] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [✅] is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Sep 11, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@Ankush263
Copy link
Contributor Author

Should I need to change something here??

@lindapaiste
Copy link
Collaborator

We’ve gotten a lot of PRs in the past few days and I haven’t had a chance to review them all yet!

We were previously looking at the keyup event. With your fix we are now looking at both the keydown (fired first) and the keyup. Is it necessary to check for “enter” on both events? It seems a little odd, but I need to check out your branch and play with it to see how it behaves.

@Ankush263
Copy link
Contributor Author

Yeah, it's odd to use both keyUp and keyDown, I tried different approaches, but this works perfectly .

@raclim
Copy link
Collaborator

raclim commented Jan 16, 2024

Since it's been a while since this PR has been updated, I've marked it with a "closing soon" label, which signifies that this PR will be closed in 10 days. Please feel free to revisit this to make any further updates or indicate that you would like to keep this open!

@raclim raclim closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot edit names on SketchList or CollectionList using keyboard controls
3 participants