Refactor DashboardView.jsx: Convert legacy class component to functional component and remove unused code #2422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akshay02022
changed the title
lindapaiste
reviewed
Sep 13, 2023
Comment on lines
110
to
116
| useEffect(() => { | ||
| if (collectionCreateVisible) { | ||
| document.body.style.overflow = 'hidden'; | ||
| } else { | ||
| document.body.style.overflow = 'auto'; | ||
| } | ||
| }, [collectionCreateVisible]); |
There was a problem hiding this comment.
Can you please explain why this is necessary?
There was a problem hiding this comment.
The extra code was intended solely for testing scrolling behavior, which is already managed within the component.
I have now removed this test code and am ready to commit.
My apologies for any confusion. All changes have been completed, and I'm creating a new Pull Request for these updates.
| const currentTab = selectedTabKey(); | ||
| const owner = isOwner(); | ||
| const { username } = params; | ||
| const actions = renderActionButton(currentTab, username, t); |
There was a problem hiding this comment.
Since you eliminated the unnecessary arguments from the function, you no longer need to pass them here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #2358
Changes:
Refactor DashboardView.jsx: Convert legacy class component to functional component and remove unused code
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123