Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #2363, Add to Collection. #2782

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

vivekbopaliya
Copy link
Contributor

@vivekbopaliya vivekbopaliya commented Dec 26, 2023

Fixes #2363

Changes:
"Add To Collection" finally working even when viewing another user's sketch list!

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I did fix this already as part of a larger cleanup in #2353 but that PR is still awaiting approval from @raclim.

This is a bug so we need to fix it ASAP so I'm going to go ahead and merge this so that we can get it fixed in the next release.

@lindapaiste lindapaiste merged commit 3a80ee6 into processing:develop Dec 28, 2023
@raclim raclim added this to the MINOR Release for 2.11.0 milestone Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Add To Collection" doesn't work when viewing another user's sketch list
3 participants