Skip to content

Fix error modal pop up#3116

Merged
raclim merged 2 commits intoprocessing:developfrom
PiyushChandra17:piyush/fix-error-modal
May 31, 2024
Merged

Fix error modal pop up#3116
raclim merged 2 commits intoprocessing:developfrom
PiyushChandra17:piyush/fix-error-modal

Conversation

@PiyushChandra17
Copy link
Copy Markdown
Contributor

Fixes #3053

Made the following changes:

  • First things first got the access of user state via useSelector hook
  • Check for user is logged in/ authenticated && logged in user is the owner of sketch
  • Then only dispatch autosaveProject actions
  • Which will eventually make the API call

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link
Copy Markdown
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this! This looks good to me!

@raclim raclim merged commit e495559 into processing:develop May 31, 2024
@PiyushChandra17
Copy link
Copy Markdown
Contributor Author

Thanks so much for working on this! This looks good to me!

On to the next one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logged out error modal pops up when downloading another user's sketch

2 participants