Skip to content

Fix redundant redirects between client and server #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

PiyushChandra17
Copy link
Contributor

@PiyushChandra17 PiyushChandra17 commented Jun 6, 2024

Fixes #2992

Changes to the client side:

  • Removed all auth checks ie. userIsAuthenticated, userIsNotAuthenticated, userIsAuthorized from routes.jsx file
  • Deleted utils/auth.js file
  • Deleted components/createRedirectWithUsername file

Changes to the server side:

  • redirect '/sketches' and '/assets' to the url with the username
  • if the user is logged in redirect '/reset-password' and 'reset-password/:reset_password_token' to '/account'

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim
Copy link
Collaborator

raclim commented Jun 24, 2024

Thanks for your work on this! This issue ultimately got addressed by an earlier PR (#2993). I'm sorry that we couldn't get this one in, but will continue to check out your other PRs!

@raclim raclim closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate redundant redirects between client and server
2 participants