Skip to content

Added accesibility for default system theme to p5.js-web-editor #3371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

takshittt
Copy link

I added a button in the settings dropdown menu as "system preferences" which enables default system theme of the user to the p5.js web editor.
Fixes #3061

Changes: added accessibility for default system theme in the p5.js-web-editor

I have verified that this pull request:

  • [✔️ ] has no linting errors (npm run lint)
  • [ ✔️] has no test errors (npm run test)
  • [ ✔️] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [ ✔️] is descriptively named and links to an issue number, i.e. Fixes #3061

@raclim raclim added Area:Accessibility Category for accessibility related features and bugs Area:CSS For styling or layout issues handled with CSS/SASS labels Mar 17, 2025
@yugalkaushik
Copy link
Contributor

To check the checkbox you can add x between the square brackets.

@takshittt
Copy link
Author

Reviewed and tested the implementation of the default system theme. Verified that theme switches correctly based on system preferences across supported browsers. Ready for review and merge.

@raclim
Copy link
Collaborator

raclim commented May 16, 2025

Thanks so much for working on this!

I just checked it out and can confirm that it seems to work so far! I'm not sure if this might've been mentioned somewhere already, but could you delve into why react-helmet-async is added? Was it specifically for testing?

@takshittt
Copy link
Author

The migration from react-helmet to react-helmet-async was primarily done for testing purposes, but not exclusively. It also helps maintain consistency between the testing and production environments. However, I realize this is a broader change that could affect the overall code workflow. I'm happy to switch back to react-helmet if you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Accessibility Category for accessibility related features and bugs Area:CSS For styling or layout issues handled with CSS/SASS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply user's system color-scheme preference as the default site theme
3 participants