-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Added accesibility for default system theme to p5.js-web-editor #3371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Added accesibility for default system theme to p5.js-web-editor #3371
Conversation
To check the checkbox you can add |
Reviewed and tested the implementation of the default system theme. Verified that theme switches correctly based on system preferences across supported browsers. Ready for review and merge. |
Thanks so much for working on this! I just checked it out and can confirm that it seems to work so far! I'm not sure if this might've been mentioned somewhere already, but could you delve into why |
The migration from react-helmet to react-helmet-async was primarily done for testing purposes, but not exclusively. It also helps maintain consistency between the testing and production environments. However, I realize this is a broader change that could affect the overall code workflow. I'm happy to switch back to react-helmet if you prefer. |
I added a button in the settings dropdown menu as "system preferences" which enables default system theme of the user to the p5.js web editor.
Fixes #3061
Changes: added accessibility for default system theme in the p5.js-web-editor
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #3061