Merged
Conversation
davepagurek
reviewed
Oct 16, 2025
Collaborator
davepagurek
left a comment
There was a problem hiding this comment.
Cool library, thanks for adding it! Just wanted to double-check the URL before merging.
Also, if your library works with p5 2.0, after this is merged, feel free to git cherry-pick the same commit into the 2.0 branch of this website and make another PR into that to get it onto the 2.0 site too. (The structure of an addon for 2.0 is a little different, see the 2.0 docs on it for info.)
| author: | ||
| name: Nick Puckett | ||
| url: https://github.com/npuckett | ||
| websiteUrl: https://npuckett.github.io/p5-phone/ |
Collaborator
There was a problem hiding this comment.
I tried going to this link and it gives me a 404, is this the right one?
Contributor
Author
|
Hi Dave,
Thanks for catching that. I tried to organize things a bit more cleanly and didn’t get it updated. The correct url is : https://npuckett.github.io/p5-phone/examples/homepage/
Thanks
Nick
… On Oct 16, 2025, at 4:27 PM, Dave Pagurek ***@***.***> wrote:
@davepagurek commented on this pull request.
Cool library, thanks for adding it! Just wanted to double-check the URL before merging.
Also, if your library works with p5 2.0, after this is merged, feel free to git cherry-pick the same commit into the 2.0 branch of this website and make another PR into that to get it onto the 2.0 site <https://beta.p5js.org/> too. (The structure of an addon for 2.0 is a little different, see the 2.0 docs on it for info. <https://github.com/processing/p5.js/blob/dev-2.0/contributor_docs/creating_libraries.md>)
In src/content/libraries/en/p5-phone.yaml <#1004 (comment)>:
> @@ -0,0 +1,13 @@
+name: p5-phone
+description: Simplified mobile hardware access for p5.js - Simplifies accessing phone hardware, locks default gestures, and add an onscreen console.
+category: hardware
+sourceUrl: https://github.com/npuckett/p5-phone
+featuredImage: ../images/p5-phone.png
+featuredImageAlt: Mobile phone displaying a p5.js sketch with on-screen debug panel showing motion sensor data and touch controls
+author:
+ name: Nick Puckett
+ url: https://github.com/npuckett
+websiteUrl: https://npuckett.github.io/p5-phone/
I tried going to this link and it gives me a 404, is this the right one?
—
Reply to this email directly, view it on GitHub <#1004 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKDHS3OZ3FEA7B22BEOFFD3X75R3AVCNFSM6AAAAACJMNZVMOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGNBWHA4DCOBXG4>.
You are receiving this because you authored the thread.
|
Contributor
Author
|
One note to that end - I would prefer that the link on the p5 site go to the repo instead of the website. The repo has all the how to’s for the library, the url is just the examples page, which is also linked at the top of the Readme in the repo.
Thanks again,
Nick
… On Oct 16, 2025, at 4:27 PM, Dave Pagurek ***@***.***> wrote:
@davepagurek commented on this pull request.
Cool library, thanks for adding it! Just wanted to double-check the URL before merging.
Also, if your library works with p5 2.0, after this is merged, feel free to git cherry-pick the same commit into the 2.0 branch of this website and make another PR into that to get it onto the 2.0 site <https://beta.p5js.org/> too. (The structure of an addon for 2.0 is a little different, see the 2.0 docs on it for info. <https://github.com/processing/p5.js/blob/dev-2.0/contributor_docs/creating_libraries.md>)
In src/content/libraries/en/p5-phone.yaml <#1004 (comment)>:
> @@ -0,0 +1,13 @@
+name: p5-phone
+description: Simplified mobile hardware access for p5.js - Simplifies accessing phone hardware, locks default gestures, and add an onscreen console.
+category: hardware
+sourceUrl: https://github.com/npuckett/p5-phone
+featuredImage: ../images/p5-phone.png
+featuredImageAlt: Mobile phone displaying a p5.js sketch with on-screen debug panel showing motion sensor data and touch controls
+author:
+ name: Nick Puckett
+ url: https://github.com/npuckett
+websiteUrl: https://npuckett.github.io/p5-phone/
I tried going to this link and it gives me a 404, is this the right one?
—
Reply to this email directly, view it on GitHub <#1004 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKDHS3OZ3FEA7B22BEOFFD3X75R3AVCNFSM6AAAAACJMNZVMOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGNBWHA4DCOBXG4>.
You are receiving this because you authored the thread.
|
Contributor
Author
|
Actually, here is a corrected Yaml file so you don't have to do that manually |
Contributor
Author
|
Thanks again for your help. I have a few more libraries in the pipeline that I’m getting cleaned up before submission.
In the meantime, I’m looking forward to seeing what people do with this one. It was developed in parallel to several studio briefs, so it has been tested by many students, but happy to contribute and have it out in the wild.
Nick
… On Oct 18, 2025, at 4:55 PM, Dave Pagurek ***@***.***> wrote:
Merged #1004 <#1004> into main.
—
Reply to this email directly, view it on GitHub <#1004 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKDHS6R7K3NBS4SAXLUKKD3YKSMDAVCNFSM6AAAAACJMNZVMOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRQGM3DEMJTGYZTMNQ>.
You are receiving this because you authored the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm looking to add my library p5-phone to the main directory