add unit tests for test/unit/accessibility/color_namer.js#8379
Closed
Piyushrathoree wants to merge 1 commit intoprocessing:dev-2.0from
Closed
add unit tests for test/unit/accessibility/color_namer.js#8379Piyushrathoree wants to merge 1 commit intoprocessing:dev-2.0from
Piyushrathoree wants to merge 1 commit intoprocessing:dev-2.0from
Conversation
perminder-17
reviewed
Jan 4, 2026
Collaborator
perminder-17
left a comment
perminder-17
left a comment
There was a problem hiding this comment.
Thanks! I’m unable to understand this PR because these tests are brittle and don’t really unit-test.
Also, They’re very brittle because they verify gridOutput() generated DOM/innerHTML (IDs and wording) rather than the actual color_namer logic. I'll be closing this one for now.
Author
|
@perminder-17 thanks for the review and feedback. I'll make sure about it next time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8377
Changes: add unit tests for test/unit/accessibility/color_namer.js
PR Checklist
npm run lintpasses