Enforce Non Empty #938
Merged
Enforce Non Empty #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yisraelU this seems like a good time to merge this as well, given that 1.8.0 will break binary compatibility anyway, what do you think? |
If we break binary compatibility don't we have to go from 1.x.x to 2.x.x? |
From
bincompat was already broken in 1.7.1 -> 1.7.2 previously. |
|
That read me should be updated. We started using MiMa already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are quite a few methods that take in varargs, however are required by Lettuce to be non empty.
This PR is going through those and systematically converting def fx(v:V*) to def fx(v:V,vs:V*)