-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
streaming ontop redis effect #985
Merged
Merged
+157
−229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmienko
commented
Mar 7, 2025
yisraelU
reviewed
Mar 7, 2025
modules/effects/src/main/scala/dev/profunktor/redis4cats/effects.scala
Outdated
Show resolved
Hide resolved
arturaz
approved these changes
Mar 14, 2025
One note: |
Good callout, it seems redundant as it is all in-memory at this point so they could be equal. Will remove. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use stream commands from the main redis-effects module in the FS2 Stream wrapper module. Update read method to be DRY. Attempt to clarify some internal methods. Follow up to #969.
Could review be commit.
This PR introduces breaking changes. Users will need to update imports, update
read
calls, and update XAddMessage to pass XAddArgs.However, in the long term these should be beneficial.
We could consider an intermediate PR to introduce some of these changes in backwards compatible way and to mark old methods as depreciated.
If we decide to go forward, would be merge this into the 1.x.x series?