Add Windows CI + fix a bunch of bugs/tests on Windows - #1657
Open
progval wants to merge 29 commits into
Open
Conversation
progval
changed the title
progval
force-pushed
the
ci-windows
branch
2 times, most recently
from
March 8, 2026 11:56
f8dd6db to
1355f84
Compare
not closing it prevent limnoria-test from cleaning the data dir on Windows
eg. this seems to be needed for Factoids' tests to close their DB.
Otherwise, ChannelDBHandler.die() is never called because IrcCallback.die() does not call super().die() (and it can't because its parent class does not have such a method)
They are noisy on Windows every time we spawn a process (and will be on POSIX when we'll switch to the 'forkserver' method). It also seems pretty bad to run them in forked processes (with the 'fork' method), I imagine it might corrupt non-atomic files because it may cause concurrent writes; in addition to writing outdated data (if data in the main process was changed since the fork started)
This fixes tests for Aka and Network on Windows
codecs.open() is deprecated, and db.DBI.remove() seems to have issues with it, as it prepends '------' to the id instead of overwriting the id.
jlu5
reviewed
Sep 13, 2026
| def sanitizeName(filename): | ||
| """Removes / from filenames and escapes them if they are '.' or '..'.""" | ||
| filename = filename.replace('/', '') | ||
| r"""Removes '/', '\', and '|' from filenames and escapes them if they are '.' or '..'.""" |
Collaborator
There was a problem hiding this comment.
For consistency, should we do the same for all reserved chars on Windows <>:"/\|?*?
This feels quite restrictive though, so maybe there should be a config toggle which only takes effect outside of Windows.
Owner
Author
There was a problem hiding this comment.
We need the same rules for people who want to switch between Linux and Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.