Skip to content

Add functions to create Kueue resources #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions support/fakeclient.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"k8s.io/apimachinery/pkg/runtime"
fakeDynamic "k8s.io/client-go/dynamic/fake"
fakeCore "k8s.io/client-go/kubernetes/fake"
fakekueue "sigs.k8s.io/kueue/client-go/clientset/versioned/fake"

fakeimage "github.com/openshift/client-go/image/clientset/versioned/fake"
fakeMachine "github.com/openshift/client-go/machine/clientset/versioned/fake"
Expand All @@ -20,6 +21,7 @@ func NewTest(t *testing.T) *T {
fakeimageClient := fakeimage.NewSimpleClientset()
fakerouteClient := fakeroute.NewSimpleClientset()
fakerayClient := fakeray.NewSimpleClientset()
fakekueueClient := fakekueue.NewSimpleClientset()
fakedynamicClient := fakeDynamic.NewSimpleDynamicClient(runtime.NewScheme())

test := With(t).(*T)
Expand All @@ -29,6 +31,7 @@ func NewTest(t *testing.T) *T {
image: fakeimageClient,
route: fakerouteClient,
ray: fakerayClient,
kueue: fakekueueClient,
dynamic: fakedynamicClient,
}
return test
Expand Down
90 changes: 90 additions & 0 deletions support/kueue.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
/*
Copyright 2024.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package support

import (
"github.com/onsi/gomega"

metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
kueuev1beta1 "sigs.k8s.io/kueue/apis/kueue/v1beta1"
)

func CreateKueueResourceFlavor(t Test, resourceFlavorSpec kueuev1beta1.ResourceFlavorSpec) *kueuev1beta1.ResourceFlavor {
t.T().Helper()

resourceFlavor := &kueuev1beta1.ResourceFlavor{
TypeMeta: metav1.TypeMeta{
APIVersion: kueuev1beta1.SchemeGroupVersion.String(),
Kind: "ResourceFlavor",
},
ObjectMeta: metav1.ObjectMeta{
GenerateName: "rf-",
},
Spec: resourceFlavorSpec,
}

resourceFlavor, err := t.Client().Kueue().KueueV1beta1().ResourceFlavors().Create(t.Ctx(), resourceFlavor, metav1.CreateOptions{})
t.Expect(err).NotTo(gomega.HaveOccurred())
t.T().Logf("Created Kueue ResourceFlavor %s successfully", resourceFlavor.Name)

return resourceFlavor
}

func CreateKueueClusterQueue(t Test, clusterQueueSpec kueuev1beta1.ClusterQueueSpec) *kueuev1beta1.ClusterQueue {
t.T().Helper()

clusterQueue := &kueuev1beta1.ClusterQueue{
TypeMeta: metav1.TypeMeta{
APIVersion: kueuev1beta1.SchemeGroupVersion.String(),
Kind: "ClusterQueue",
},
ObjectMeta: metav1.ObjectMeta{
GenerateName: "cq-",
},
Spec: clusterQueueSpec,
}

clusterQueue, err := t.Client().Kueue().KueueV1beta1().ClusterQueues().Create(t.Ctx(), clusterQueue, metav1.CreateOptions{})
t.Expect(err).NotTo(gomega.HaveOccurred())
t.T().Logf("Created Kueue ClusterQueue %s successfully", clusterQueue.Name)

return clusterQueue
}

func CreateKueueLocalQueue(t Test, namespace, clusterQueueName string) *kueuev1beta1.LocalQueue {
t.T().Helper()

localQueue := &kueuev1beta1.LocalQueue{
TypeMeta: metav1.TypeMeta{
APIVersion: kueuev1beta1.SchemeGroupVersion.String(),
Kind: "LocalQueue",
},
ObjectMeta: metav1.ObjectMeta{
GenerateName: "lq-",
Namespace: namespace,
},
Spec: kueuev1beta1.LocalQueueSpec{
ClusterQueue: kueuev1beta1.ClusterQueueReference(clusterQueueName),
},
}

localQueue, err := t.Client().Kueue().KueueV1beta1().LocalQueues(namespace).Create(t.Ctx(), localQueue, metav1.CreateOptions{})
t.Expect(err).NotTo(gomega.HaveOccurred())
t.T().Logf("Created Kueue LocalQueue %s/%s successfully", localQueue.Namespace, localQueue.Name)

return localQueue
}
61 changes: 61 additions & 0 deletions support/kueue_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
/*
Copyright 2024.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package support

import (
"testing"

"github.com/onsi/gomega"

metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
kueuev1beta1 "sigs.k8s.io/kueue/apis/kueue/v1beta1"
)

func TestCreateKueueResourceFlavor(t *testing.T) {
test := NewTest(t)

rfSpec := kueuev1beta1.ResourceFlavorSpec{}

rf := CreateKueueResourceFlavor(test, rfSpec)

test.Expect(rf).To(gomega.Not(gomega.BeNil()))
test.Expect(rf.GenerateName).To(gomega.Equal("rf-"))
}

func TestCreateKueueClusterQueue(t *testing.T) {
test := NewTest(t)

cqSpec := kueuev1beta1.ClusterQueueSpec{
NamespaceSelector: &metav1.LabelSelector{},
}

cq := CreateKueueClusterQueue(test, cqSpec)

test.Expect(cq).To(gomega.Not(gomega.BeNil()))
test.Expect(cq.GenerateName).To(gomega.Equal("cq-"))
}

func TestCreateKueueLocalQueue(t *testing.T) {
test := NewTest(t)

lq := CreateKueueLocalQueue(test, "ns-1", "cq-1")

test.Expect(lq).To(gomega.Not(gomega.BeNil()))
test.Expect(lq.GenerateName).To(gomega.Equal("lq-"))
test.Expect(lq.Namespace).To(gomega.Equal("ns-1"))
test.Expect(lq.Spec.ClusterQueue).To(gomega.Equal(kueuev1beta1.ClusterQueueReference("cq-1")))
}