Skip to content

Add local-queue annotation to use created local queue by default in g… #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

abhijeet-dhumal
Copy link
Contributor

@abhijeet-dhumal abhijeet-dhumal commented Jul 31, 2024

Issue link

opendatahub-io/distributed-workloads#198

What changes have been made

  • Use annotation to allow creating raycluster using default local-queue created in given namespace
  • Add support for providing AWS_DEFAULT_REGION environment variable

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Contributor

@Srihari1192 Srihari1192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot removed the lgtm label Aug 1, 2024
@astefanutti
Copy link
Collaborator

/lgtm

@astefanutti
Copy link
Collaborator

@abhijeet-dhumal could you make sure to run openshift-goimports so it passes the checks.

@openshift-ci openshift-ci bot removed the lgtm label Aug 2, 2024
@openshift-ci openshift-ci bot added the lgtm label Aug 2, 2024
Copy link

openshift-ci bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhijeet-dhumal, astefanutti, Srihari1192

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e1eb0ff into project-codeflare:main Aug 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants