-
Notifications
You must be signed in to change notification settings - Fork 54
Disconnected demo #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-bot
merged 7 commits into
project-codeflare:main
from
dimakis:disconnected-demo
Nov 20, 2023
Merged
Disconnected demo #403
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7b40e5c
refactor: add disconnected mnist training script
dimakis 37bb9a0
refactor: addition of the mnist download script for use with disconne…
dimakis fcf4996
refactor: addition of note to test in disconnected env
dimakis cf6c9f3
style: black formatting for precommit
dimakis 30160bf
refactor: correct path to datasets
dimakis 32a8a8b
fix: fix paths to datasets
dimakis 1253371
feat: make it easier to download the datasets
dimakis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
# Copyright 2022 IBM, Red Hat | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import os | ||
from torchvision.datasets import MNIST | ||
from torchvision import transforms | ||
|
||
|
||
def download_mnist_dataset(destination_dir): | ||
# Ensure the destination directory exists | ||
if not os.path.exists(destination_dir): | ||
os.makedirs(destination_dir) | ||
|
||
# Define transformations | ||
transform = transforms.Compose( | ||
[transforms.ToTensor(), transforms.Normalize((0.1307,), (0.3081,))] | ||
) | ||
|
||
# Download the training data | ||
train_set = MNIST( | ||
root=destination_dir, train=True, download=True, transform=transform | ||
) | ||
|
||
# Download the test data | ||
test_set = MNIST( | ||
root=destination_dir, train=False, download=True, transform=transform | ||
) | ||
|
||
print(f"MNIST dataset downloaded in {destination_dir}") | ||
|
||
|
||
# Specify the directory where you | ||
destination_dir = os.path.dirname(os.path.abspath(__file__)) | ||
|
||
download_mnist_dataset(destination_dir) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,164 @@ | ||
# Copyright 2022 IBM, Red Hat | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
# In[] | ||
import os | ||
|
||
import torch | ||
from pytorch_lightning import LightningModule, Trainer | ||
from pytorch_lightning.callbacks.progress import TQDMProgressBar | ||
from pytorch_lightning.loggers import CSVLogger | ||
from torch import nn | ||
from torch.nn import functional as F | ||
from torch.utils.data import DataLoader, random_split | ||
from torchmetrics import Accuracy | ||
from torchvision import transforms | ||
from torchvision.datasets import MNIST | ||
|
||
PATH_DATASETS = os.environ.get("PATH_DATASETS", ".") | ||
BATCH_SIZE = 256 if torch.cuda.is_available() else 64 | ||
# %% | ||
|
||
local_minst_path = os.path.dirname(os.path.abspath(__file__)) | ||
|
||
print("prior to running the trainer") | ||
print("MASTER_ADDR: is ", os.getenv("MASTER_ADDR")) | ||
print("MASTER_PORT: is ", os.getenv("MASTER_PORT")) | ||
|
||
|
||
class LitMNIST(LightningModule): | ||
def __init__(self, data_dir=PATH_DATASETS, hidden_size=64, learning_rate=2e-4): | ||
super().__init__() | ||
|
||
# Set our init args as class attributes | ||
self.data_dir = data_dir | ||
self.hidden_size = hidden_size | ||
self.learning_rate = learning_rate | ||
|
||
# Hardcode some dataset specific attributes | ||
self.num_classes = 10 | ||
self.dims = (1, 28, 28) | ||
channels, width, height = self.dims | ||
self.transform = transforms.Compose( | ||
[ | ||
transforms.ToTensor(), | ||
transforms.Normalize((0.1307,), (0.3081,)), | ||
] | ||
) | ||
|
||
# Define PyTorch model | ||
self.model = nn.Sequential( | ||
nn.Flatten(), | ||
nn.Linear(channels * width * height, hidden_size), | ||
nn.ReLU(), | ||
nn.Dropout(0.1), | ||
nn.Linear(hidden_size, hidden_size), | ||
nn.ReLU(), | ||
nn.Dropout(0.1), | ||
nn.Linear(hidden_size, self.num_classes), | ||
) | ||
|
||
self.val_accuracy = Accuracy() | ||
self.test_accuracy = Accuracy() | ||
|
||
def forward(self, x): | ||
x = self.model(x) | ||
return F.log_softmax(x, dim=1) | ||
|
||
def training_step(self, batch, batch_idx): | ||
x, y = batch | ||
logits = self(x) | ||
loss = F.nll_loss(logits, y) | ||
return loss | ||
|
||
def validation_step(self, batch, batch_idx): | ||
x, y = batch | ||
logits = self(x) | ||
loss = F.nll_loss(logits, y) | ||
preds = torch.argmax(logits, dim=1) | ||
self.val_accuracy.update(preds, y) | ||
|
||
# Calling self.log will surface up scalars for you in TensorBoard | ||
self.log("val_loss", loss, prog_bar=True) | ||
self.log("val_acc", self.val_accuracy, prog_bar=True) | ||
|
||
def test_step(self, batch, batch_idx): | ||
x, y = batch | ||
logits = self(x) | ||
loss = F.nll_loss(logits, y) | ||
preds = torch.argmax(logits, dim=1) | ||
self.test_accuracy.update(preds, y) | ||
|
||
# Calling self.log will surface up scalars for you in TensorBoard | ||
self.log("test_loss", loss, prog_bar=True) | ||
self.log("test_acc", self.test_accuracy, prog_bar=True) | ||
|
||
def configure_optimizers(self): | ||
optimizer = torch.optim.Adam(self.parameters(), lr=self.learning_rate) | ||
return optimizer | ||
|
||
#################### | ||
# DATA RELATED HOOKS | ||
#################### | ||
|
||
def prepare_data(self): | ||
# download | ||
print("Preparing MNIST dataset...") | ||
MNIST(self.data_dir, train=True, download=False) | ||
MNIST(self.data_dir, train=False, download=False) | ||
|
||
def setup(self, stage=None): | ||
# Assign train/val datasets for use in dataloaders | ||
if stage == "fit" or stage is None: | ||
mnist_full = MNIST( | ||
self.data_dir, train=True, transform=self.transform, download=False | ||
) | ||
self.mnist_train, self.mnist_val = random_split(mnist_full, [55000, 5000]) | ||
|
||
# Assign test dataset for use in dataloader(s) | ||
if stage == "test" or stage is None: | ||
self.mnist_test = MNIST( | ||
self.data_dir, train=False, transform=self.transform, download=False | ||
) | ||
|
||
def train_dataloader(self): | ||
return DataLoader(self.mnist_train, batch_size=BATCH_SIZE) | ||
|
||
def val_dataloader(self): | ||
return DataLoader(self.mnist_val, batch_size=BATCH_SIZE) | ||
|
||
def test_dataloader(self): | ||
return DataLoader(self.mnist_test, batch_size=BATCH_SIZE) | ||
|
||
|
||
# Init DataLoader from MNIST Dataset | ||
|
||
model = LitMNIST(data_dir=local_minst_path) | ||
|
||
print("GROUP: ", int(os.environ.get("GROUP_WORLD_SIZE", 1))) | ||
print("LOCAL: ", int(os.environ.get("LOCAL_WORLD_SIZE", 1))) | ||
|
||
# Initialize a trainer | ||
trainer = Trainer( | ||
accelerator="auto", | ||
# devices=1 if torch.cuda.is_available() else None, # limiting got iPython runs | ||
max_epochs=5, | ||
callbacks=[TQDMProgressBar(refresh_rate=20)], | ||
num_nodes=int(os.environ.get("GROUP_WORLD_SIZE", 1)), | ||
devices=int(os.environ.get("LOCAL_WORLD_SIZE", 1)), | ||
strategy="ddp", | ||
) | ||
|
||
# Train the model ⚡ | ||
trainer.fit(model) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.