Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EC2 attribute error #5510

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix EC2 attribute error #5510

wants to merge 3 commits into from

Conversation

myersCody
Copy link
Contributor

Jira Ticket

Description

This change will fix an attribute error that fires in prod.

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoint or launch shell
    1. You should see ...
  4. Do more things...

Release Notes

  • proposed release note
* [COST-####](https://issues.redhat.com/browse/COST-####) Fix some things

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.1%. Comparing base (1162f07) to head (441a854).

❌ Your patch check has failed because the patch coverage (83.3%) is below the target coverage (90.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5510   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        371     371           
  Lines      31598   31599    +1     
  Branches    3383    3384    +1     
=====================================
+ Hits       29732   29734    +2     
+ Misses      1215    1214    -1     
  Partials     651     651           

@myersCody myersCody added the smoke-tests pr_check will build the image and run minimal required smokes label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants