-
Notifications
You must be signed in to change notification settings - Fork 0
general modbus entity/service #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Dockerfile
Outdated
|
|
||
| FROM ${img_user}/${img_repo}:${img_tag} | ||
|
|
||
| RUN pip install pymodbus slack_sdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should remove slack_sdk from this PR (that's from your working code on slack integration)
| @@ -0,0 +1,3 @@ | |||
| __all__ = [] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nsoblath : should we have these extensions flat in the dripline/extensions/ directory? or in their own subdirectory like jitter was (doesn't seem to add value)
|
We should cross-compare and harmonize with #223 |
…y this the byteorder argument gets oppsolate and the wordorder argument has to be part of the entity not the service. Service now returns the register bytes and entity has to decode them.
… and single value.
… apply type conversion to set method
|
So you can only define the endian-ness of the word order and not the byte order now? I'm hoping this doesn't cause issues for any devices down the road. The documentation on the new method seems thin, with a lot of the docs still using BinaryPayloadDecoder despite the deprecation warnings, but that's a developer side issue. Our device is offline right now, so can't test. Will have to work out any issues on a hot fix. I may go back and allow endianness to be defined at a Service level, since that should be a device property and not require specification at the individual entity level. |
According to the MODBUS Application Protocol (2012) see e.g. |
…r individual read and write attempts
|
@wcpettus I have implemented your suggestions and also made the wordorder again a service property. I fully agree that this just makes sense. Since also the test builds work and we have no conflict with develop we are ready to merge. |

No description provided.