Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openseadragon fixes #159

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Openseadragon fixes #159

merged 2 commits into from
Oct 11, 2024

Conversation

marlo-longley
Copy link
Collaborator

@marlo-longley marlo-longley commented Oct 9, 2024

Closes #3178
This was tested as part of a Spotlight application.

Changes:

  1. the custom icons had stopped working because the ViewComponent was generating sequential ids (so 1-zoom-in 2-zoom-out) rather than using a consistent id for all control elements.

2. I wasn't able to get tests to pass without changes to the @presenter setup, which mimics the setup in the other ViewComponents.

  1. In testing this work I found that multi-page items were rendering incorrectly. It seems that the options/params expected by OSD have changed: I needed to add sequenceMode: true, and I was able to remove other options that were set by default. Before (goes to last page and is just broken):
Screenshot 2024-10-09 at 3 45 02 PM

After:
Screenshot 2024-10-09 at 3 45 21 PM

@marlo-longley marlo-longley marked this pull request as ready for review October 9, 2024 21:02
@marlo-longley
Copy link
Collaborator Author

@jcoyne thank you for reviewing. I addressed your comments.

@dnoneill dnoneill merged commit f4549ad into main Oct 11, 2024
7 checks passed
@dnoneill dnoneill deleted the osd-fixes branch October 11, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: duplicate openseadragon controls
3 participants