Robustness improvements to buendia-wifi-watchdog#249
Open
Conversation
…s associated. This will work even when connected to an open network.
Contributor
|
@schuyler Quick question here—why is |
Member
Author
The only good answer I have is that it works when A less good answer is that Happy to take out this particular commit out of the PR if we're concerned about this choice. |
Member
Author
|
@zestyping bump for review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some improvements to
buendia-wifi-watchdogmade while testing #247 in the hopes of making it more robust:iwconfigrather thanwpa_clito ensure that what we're looking at is network association, and ensure thatwireless-toolsis required by the packageipto check that we actually have an IP addressTested on the NUC by watching
buendia-wifi-watchdog.logfor several minutes, both with the network unconfigured and subsequently configured, to ensure the desired behavior. Also tested with and without a wifi interface defined. Performed same manual tests across multiple boots for confirmation.