Suppress messages during resolution #3956
Open
+67
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s during resolution
|
I've tested this change against the actual code that demonstrated #3947 and it appears to be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3954 and #3947
DiscardDiagnosticHandlerthat is designed exactly for this purpose and is also used by the compiler itself.LinkedListto be compatible with all known versions of theLogclass. I also noticed that this code was broken a long time and even if I remove it all our tests pass. Might be possible to remove all that stuff.comparemethod inJavacResolutiondoesn't work because the usedName::compareToreturns different results in Java 8