Illustrate the expected NOTICE/LICENSE#10338
Illustrate the expected NOTICE/LICENSE#10338jbonofre wants to merge 1 commit intoprojectnessie:mainfrom
Conversation
|
|
|
I can apply this to #10331 but I wanted to illustrate and provide what should be included or not included. |
dimas-b
left a comment
dimas-b
left a comment
There was a problem hiding this comment.
This approach make sense to me 👍
I'm not sure about some specific listed dependencies, though :)
|
|
||
| Apache Polaris (incubating) | ||
| Copyright The Apache Software Foundation | ||
| | Apache Iceberg |
There was a problem hiding this comment.
Is it standard to use | as the prefix on included lines?
There was a problem hiding this comment.
It's a way to clearly format the NOTICE file from dependency (to avoid to confuse the reader). It's used in several ASF projects.
|
|
||
| -------------------------------------------------------------------------- | ||
|
|
||
| This binary artifact bundles EnvoyProxy. |
There was a problem hiding this comment.
Really? Where does EnvoyProxy get bundled?
There was a problem hiding this comment.
@jbonofre : do you have any particular methodology for checking bundled stuff?
There was a problem hiding this comment.
It's a transitive from gRPC: envoyproxy is shaded in gRPC:
$ jar tvf nessie-cli-0.102.5-SNAPSHOT.jar|grep -i envoyproxy
...
2713 Tue Dec 10 17:19:14 CET 2024 io/grpc/xds/shaded/io/envoyproxy/pgv/validate/Validate$FieldRules$1.class
17354 Tue Dec 10 17:19:14 CET 2024 io/grpc/xds/shaded/io/envoyproxy/pgv/validate/Validate$Fixed64Rules.class
20939 Tue Dec 10 17:19:14 CET 2024 io/grpc/xds/shaded/io/envoyproxy/pgv/validate/Validate$UInt64Rules$Builder.class
1260 Tue Dec 10 17:19:14 CET 2024 io/grpc/xds/shaded/io/envoyproxy/pgv/validate/Validate$DurationRulesOrBuilder.class
1212 Tue Dec 10 17:19:14 CET 2024 io/grpc/xds/shaded/io/envoyproxy/pgv/validate/Validate$KnownRegex$1.class
20839 Tue Dec 10 17:19:14 CET 2024 io/grpc/xds/shaded/io/envoyproxy/pgv/validate/Validate$SInt32Rules$Builder.class
To check, I check what is actually in the distributed jar using jar tvf foobar.jar.
There was a problem hiding this comment.
Thx! Good find :)
I wonder, though, why cli even gets gRPC 🤔
| @@ -0,0 +1 @@ | |||
| Add LICENSE/NOTICE for gc-tool | |||
There was a problem hiding this comment.
Should we have this for every published jar?
There was a problem hiding this comment.
NB: TODO is because I know gc-tool is shading dependencies, but I didn't have time to list yet. I will do that today.
There was a problem hiding this comment.
No, I mean we should do this exercise for every published jar, right?.. or only for "fat" jars?
| @@ -0,0 +1,631 @@ | |||
| Nessie | |||
| Copyright 2015-2025 Dremio Corporation | |||
There was a problem hiding this comment.
Do you mean this NOTICE to be included into the jar too?
There was a problem hiding this comment.
Yes as the NOTICE might be specific (depending of the bundled dependencies).
3 participants
This PR illustrates what should be in
LICENSEandNOTICE.LICENSEandNOTICEare for source distributionLICENSE-BINARY-DISTandNOTICE-BINARY-DISTare for all jar by defaultcli/cli/LICENSEandcli/cli/NOTICEare for the nessie-cli jar (I provide an example of expected content here)gc/gc-tool/LICENSEandgc/gc-tool/NOTICEare for the gc-tool jaarservers/quarkus-server/runner/LICENSEandservers/quarkus-server/runner/NOTICEare for the Quarkus fat jar for nessie-servertools/server-admin/runner/LICENSEandtools/server-admin/runner/NOTICEare for the Quarkus fat jar for nessie-admin-server