Refactor Loki component configuration#12
Merged
Conversation
DebakelOrakel
changed the title
DebakelOrakel
force-pushed
the
refactor/helmvalues-rendering
branch
from
d9830f5 to
28a6e7b
Compare
DebakelOrakel
force-pushed
the
refactor/helmvalues-rendering
branch
from
28a6e7b to
2be0379
Compare
simu
reviewed
May 12, 2026
simu
left a comment
simu
left a comment
Member
There was a problem hiding this comment.
The PR has a meaningful description that sums up the change. It will be linked in the changelog.
Arguably, this PR doesn't fulfil this criteria. I have no idea what to look for when reviewing this since there's 0 context on whether this PR should introduce changes in the default config etc.
Template version: main (84ac816)
DebakelOrakel
force-pushed
the
refactor/helmvalues-rendering
branch
2 times, most recently
from
5331dc7 to
c94135d
Compare
DebakelOrakel
force-pushed
the
refactor/helmvalues-rendering
branch
3 times, most recently
from
0fc176d to
792d965
Compare
DebakelOrakel
force-pushed
the
refactor/helmvalues-rendering
branch
from
792d965 to
45c2df5
Compare
simu
reviewed
May 13, 2026
DebakelOrakel
force-pushed
the
refactor/helmvalues-rendering
branch
2 times, most recently
from
777a1e1 to
509c4ed
Compare
simu
reviewed
May 21, 2026
DebakelOrakel
force-pushed
the
refactor/helmvalues-rendering
branch
from
509c4ed to
569e996
Compare
simu
approved these changes
May 21, 2026
simu
left a comment
simu
left a comment
Member
There was a problem hiding this comment.
Probably fine. I only checked the default test case diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aimes to provide a more integrated way to configure the different Loki components.
It also provides a preset "none", "legacy" and "extra-small" for scaling deployments.
The preset "none" uses Helm chart defaults
The preset "legacy" is the default and uses the previous defaults for deployment method "SimpleScalable"
and is intended for upgrading to this version of the component.
The preset "extra-small" is intended for deployment method "Distributed".
S3 configuration provides mechanism to calculate the endpoint for Cloudscale and Exoscale from cluster facts.
Additional test cases are added.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.