Skip to content

Add logic in Steward to delete bootstrap ArgoCD#198

Merged
simu merged 3 commits into
masterfrom
feat/cleanup-bootstrap-argocd
Jun 5, 2026
Merged

Add logic in Steward to delete bootstrap ArgoCD#198
simu merged 3 commits into
masterfrom
feat/cleanup-bootstrap-argocd

Conversation

@simu

@simu simu commented Jun 4, 2026

Copy link
Copy Markdown
Member

This PR introduces a new method which deletes the bootstrap ArgoCD resources (deployments, statefulsets and services with label steward.syn.tools/bootstrap=true). This method is called once a minute as soon as Steward sees that an ArgoCD custom resource is present on the cluster.

This should reduce the complexity and brittleness of the cluster bootstrap process by completely encapsulating the responsibility for bootstrap cleanup in Steward, rather than having part of the cleanup in component-argocd.

Additionally, the PR removes the now unnecessary ArgoCD sync-options annotations from the bootstrap ArgoCD resources.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

@simu simu added the enhancement New feature or request label Jun 4, 2026

@haasad haasad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simu simu force-pushed the feat/cleanup-bootstrap-argocd branch from f1cc631 to ad0785e Compare June 4, 2026 15:27
simu added 2 commits June 4, 2026 17:35
This commit introduces a new method which deletes the bootstrap ArgoCD
resources (`deployments`, `statefulsets` and `services` with label
`steward.syn.tools/bootstrap=true`). This method is called once a minute
as soon as Steward sees that an `ArgoCD` custom resource is present on
the cluster.

This should reduce the complexity and brittleness of the cluster
bootstrap process by completely encapsulating the responsibility for
bootstrap cleanup in Steward, rather than having part of the cleanup in
component-argocd.
@simu simu force-pushed the feat/cleanup-bootstrap-argocd branch from ad0785e to e80c170 Compare June 4, 2026 15:35
@simu simu merged commit 58da6a2 into master Jun 5, 2026
3 checks passed
@simu simu deleted the feat/cleanup-bootstrap-argocd branch June 5, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants