Skip to content

Gitlab Collector: Slow Query Collector and Test #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 82 additions & 0 deletions collector/pg_slow.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
// Copyright 2023 The Prometheus Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package collector

import (
"context"

"github.com/go-kit/log"
"github.com/prometheus/client_golang/prometheus"
)

const slowSubsystem = "slow"

func init() {
registerCollector(slowSubsystem, defaultDisabled, NewPGSlowCollector)
}

type PGSlowCollector struct {
log log.Logger
}

func NewPGSlowCollector(config collectorConfig) (Collector, error) {
return &PGSlowCollector{log: config.logger}, nil
}

var (
slowQueries = prometheus.NewDesc(
prometheus.BuildFQName(namespace, slowSubsystem, "queries"),
"Current number of slow queries",
[]string{},
prometheus.Labels{},
)

slowQuery = `
SELECT
COUNT(*) AS queries
FROM
pg_catalog.pg_stat_activity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already a pg_stat_activity query in cmd/postgres_exporter/queries.go. Perhaps we should refactor this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in put it in queries.go? The other ones do a set of group bys which we couldn't really shove into this query

WHERE
state = 'active' AND (now() - query_start) > '1 seconds'::interval
`
)

func (PGSlowCollector) Update(ctx context.Context, instance *instance, ch chan<- prometheus.Metric) error {
db := instance.getDB()
rows, err := db.QueryContext(ctx,
slowQuery)

if err != nil {
return err
}
defer rows.Close()

for rows.Next() {
var queries float64

if err := rows.Scan(&queries); err != nil {
return err
}

ch <- prometheus.MustNewConstMetric(
slowQueries,
prometheus.GaugeValue,
queries,
)
}
if err := rows.Err(); err != nil {
return err
}
return nil
}
61 changes: 61 additions & 0 deletions collector/pg_slow_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
// Copyright 2023 The Prometheus Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package collector

import (
"context"
"testing"

"github.com/DATA-DOG/go-sqlmock"
"github.com/prometheus/client_golang/prometheus"
dto "github.com/prometheus/client_model/go"
"github.com/smartystreets/goconvey/convey"
)

func TestPGSlowCollector(t *testing.T) {
db, mock, err := sqlmock.New()
if err != nil {
t.Fatalf("Error opening a stub db connection: %s", err)
}
defer db.Close()
inst := &instance{db: db}
columns := []string{
"queries",
}
rows := sqlmock.NewRows(columns).
AddRow(25)

mock.ExpectQuery(sanitizeQuery(slowQuery)).WillReturnRows(rows)

ch := make(chan prometheus.Metric)
go func() {
defer close(ch)
c := PGSlowCollector{}

if err := c.Update(context.Background(), inst, ch); err != nil {
t.Errorf("Error calling PGSlowCollector.Update: %s", err)
}
}()
expected := []MetricResult{
{labels: labelMap{}, value: 25, metricType: dto.MetricType_GAUGE},
}
convey.Convey("Metrics comparison", t, func() {
for _, expect := range expected {
m := readMetric(<-ch)
convey.So(expect, convey.ShouldResemble, m)
}
})
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("there were unfulfilled exceptions: %s", err)
}
}