Reduce allocations of TextSerializer #410
Open
Stabzs wants to merge 2 commits into
Open
Conversation
added 2 commits
March 26, 2023 14:49
…s to byte arrays via intermediary buffers instead of creating intermediary strings.
Author
|
@sandersaares Is there anything you need me to take action on for this PR? As far as I can tell, the build issues are not related to my changes. |
|
This looks really nice 👏 Hope we can see this in an upcoming release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces the allocations of TextSerializer by converting double/long values to byte arrays via intermediary buffers instead of creating intermediary strings. It does this by taking advantage of UftFormatters from the System.Memory assembly. All unit tests continue to pass as expected.
SerializationBenchmarks showed a 50% allocation reduction for CollectAndSerialize, while it brought CollectAndSerializeOpenMetrics down 66% into alignment with CollectAndSerialize. Since the runs of both benchmarks are bimodal, runtimes are difficult to compare although in my tests, they were unchanged and/or showed no significant differences.
Existing:
Optimized:
NOTE: there are potential opportunities to use UTF8 literals in other places to minimize allocations on startup, but that seems like a separate effort.