Use model.Duration for timeout option in webhook notifier#4430
Closed
alexander-akhmetov wants to merge 1 commit into
Closed
Use model.Duration for timeout option in webhook notifier#4430alexander-akhmetov wants to merge 1 commit into
alexander-akhmetov wants to merge 1 commit into
Conversation
1bf359d to
0545aa5
Compare
Signed-off-by: Alexander Akhmetov <me@alx.cx>
0545aa5 to
1c49704
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed webhook timeout field from
time.Durationtomodel.Durationto make JSON marshalling consistent with YAML.time.Durationmarshals to JSON as an integer (nanoseconds), while to YAML (withgopkg.in/yaml.v3) it's marshalled as a duration string.time.Durationexample: https://go.dev/play/p/Ml2Mb_VFNyu:model.Durationalso marshals to human-readable duration strings in both JSON and YAML, and is consistent with other duration fields in Alertmanager.model.Durationexample: https://go.dev/play/p/rqts9yDSEQL