Replace example matcher from env=\"production\" to env=\"staging\ #4517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demkkka
force-pushed
the
Replace-env-production-with-env-staging
branch
from
2adc1ca to
1fb4805
Compare
- Updated exampleMatcher constant in FilterBar/Views.elm - Updated asset/assets_vfsdata.go with new frontend build Signed-off-by: Dmitry Abramov <[email protected]>
demkkka
force-pushed
the
Replace-env-production-with-env-staging
branch
from
1fb4805 to
c6dd407
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the example
exampleMatcherconfiguration to improve safety when users define their own environment-specific silences. Previously, users might mistakenly create silences targeting a production environment (e.g., withenv="production") when they intended to target staging. Such configuration errors can lead to silencing production alerts unintentionally, which poses significant risks.To address this, I changed the example to prioritize silencing staging (
env="staging") in case of misconfiguration. This approach minimizes potential impact if users make mistakes while adapting the example for their use case.I'd appreciate any feedback or suggestions on this approach! Thanks!