Integer-only Counters #1464
Open
Integer-only Counters #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 10, 2024 12:38
Signed-off-by: Not Rob Pike <[email protected]>
indeed the ival and fval can get updated separately, but such update is always one or the other, not both.
|
There are 2 lint failures. One of them exists in main already and is not due to any change in this PR. The other is introduced because the |
dswarbrick
reviewed
Aug 16, 2024
| @@ -23,6 +23,9 @@ import ( | |||
| "google.golang.org/protobuf/types/known/timestamppb" | |||
| ) | |||
|
|
|||
| // 64-bit float mantissa: https://en.wikipedia.org/wiki/Double-precision_floating-point_format | |||
| var float64Mantissa uint64 = 9007199254740992 | |||
There was a problem hiding this comment.
Shouldn't this really be a const instead of a var? IMHO it would also be clearer and more legible if it were defined as 1 << 53 rather than a long decimal number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid rounding error for large-valued Counters.
@ArthurSens @bwplotka @kakkoyun