Skip to content

feat: impl<T: Collector> Collector for std::sync::Arc<T> #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2025
Merged

feat: impl<T: Collector> Collector for std::sync::Arc<T> #273

merged 2 commits into from
Aug 14, 2025

Conversation

@hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Jul 22, 2025 •
edited
Loading

This PR implements Collector for std::sync::Arc<T> where T: Collector. This is useful for registering an Arc pointer of the metrics collector instead of wrapping collector fields with Arc

@hanabi1224 hanabi1224 marked this pull request as ready for review July 22, 2025 11:23
mxinden
mxinden reviewed Aug 14, 2025
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. Thanks.

You would need to add a git --signoff to your commit in order for us to merge.

@hanabi1224 hanabi1224 force-pushed the impl-collector-for-arc branch from 80fe980 to 76d7b30 Compare August 14, 2025 08:29
@mxinden mxinden merged commit 970606a into prometheus:master Aug 14, 2025
10 checks passed
@hanabi1224 hanabi1224 deleted the impl-collector-for-arc branch August 14, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxinden mxinden mxinden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hanabi1224 @mxinden