Update Go #770
Update Go #770
Conversation
SuperQ
commented
Mar 13, 2025
SuperQ
commented
- Update Go to support 1.24.
- Update minimum Go version to 1.23.0.
- Bump Go modules.
* Update Go to support 1.24. * Update minimum Go version to 1.23.0. * Bump Go modules. Signed-off-by: SuperQ <[email protected]>
| @@ -1,6 +1,6 @@ | |||
| module github.com/prometheus/common | |||
|
|
|||
| go 1.21 | |||
| go 1.23.0 | |||
There was a problem hiding this comment.
Would this force golang to set their minimum go version to 1.23 as well? I believe we're still in 1.22 over there 🤔
There was a problem hiding this comment.
Yes, unfortunately, the upstream Go maintainers (golang.org/x/oauth2) have set this as a minimum requirement.
There's now a upstream Go bot auto-updating this: golang/oauth2@3f78298
We'll have to reconsider our support policy for client_golang versions. 😿
|
Ping client_golang maintainers. Upstream Go is now bumping minimum Go versions in This is blocking some updates that are making vulnerability scanners complain. Even if there are no actual issues it would be good to move forward with updating our Go version support in common/client_golang to match. |
