Skip to content

chore: make custom metrics more obviously clickable #3682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

typpo
Copy link
Contributor

@typpo typpo commented Apr 11, 2025

No description provided.

Copy link
Contributor

gru-agent bot commented Apr 11, 2025

TestGru Assignment

Summary

Link CommitId Status Reason
Detail 7b45173 🚫 Skipped No files need to be tested {"src/app/src/pages/eval/components/CustomMetrics.css":"target file(src/app/src/pages/eval/components/CustomMetrics.css) not in work scope \n include: src \n exclude: node_modules,/*.test.ts,/.test.tsx,**/.spec.ts,/*.spec.tsx,/.d.ts,**/.test.js,/*.spec.js,src/app/src","src/app/src/pages/eval/components/CustomMetrics.tsx":"target file(src/app/src/pages/eval/components/CustomMetrics.tsx) not in work scope \n include: src \n exclude: node_modules,/.test.ts,**/.test.tsx,/*.spec.ts,/.spec.tsx,**/.d.ts,/*.test.js,/*.spec.js,src/app/src"}

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

Copy link
Contributor

gru-agent bot commented Apr 11, 2025

TestGru Assignment

Summary

Link CommitId Status Reason
Detail 7b45173 🚫 Skipped No files need to be tested {"src/app/src/pages/eval/components/CustomMetrics.css":"target file(src/app/src/pages/eval/components/CustomMetrics.css) not in work scope \n include: src/app/src//*.ts \n exclude: node_modules,/.test.ts,**/.test.tsx,/*.spec.ts,/.spec.tsx,**/.d.ts,/*.test.js,/.spec.js","src/app/src/pages/eval/components/CustomMetrics.tsx":"target file(src/app/src/pages/eval/components/CustomMetrics.tsx) not in work scope \n include: src/app/src/**/.ts \n exclude: node_modules,/*.test.ts,/.test.tsx,**/.spec.ts,/*.spec.tsx,/.d.ts,**/.test.js,**/*.spec.js"}

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

{metricTotals && metricTotals[metric] ? (
metricTotals[metric] === 0 ? (
<span data-testid={`metric-value-${metric}`}>0%</span>
onSearchTextChange ? (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metric rendering logic is duplicated between the tooltip and non-tooltip branches. Consider extracting the common rendering code into a helper function to improve maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant