Conversation
bdon
reviewed
Apr 30, 2025
wipfli
commented
May 9, 2025
Collaborator
Author
|
This now looks all ready:
I made a change in the styling to have a failing render test above. You can click on the render test ci and then go to the "Upload render tests results.html on failure" job. This brings you to a link where you can download a zip file containing the CI's render test results.html file. Download an open it and you will see this:
|
wipfli
commented
May 9, 2025
wipfli
commented
May 9, 2025
bdon
reviewed
May 11, 2025
bdon
approved these changes
May 11, 2025
Member
|
LGTM, can merge after reverting the intentional breakage for CI failure |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.