Add to_standard_orientation for SurfaceRZFourier#103
Merged
scadena-pf merged 1 commit intoproximafusion:mainfrom Feb 11, 2026
Merged
Add to_standard_orientation for SurfaceRZFourier#103scadena-pf merged 1 commit intoproximafusion:mainfrom
scadena-pf merged 1 commit intoproximafusion:mainfrom
Conversation
Normalizes the poloidal angle parametrization of stellarator-symmetric surfaces so that theta=0 is on the outboard side and theta increases counterclockwise in an R-Z cross-section. Reuses existing evaluate_points_rz and _evaluate_dz_dtheta to detect the current orientation, then applies Fourier coefficient transformations (theta shift by pi and/or theta sign flip) as needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
amerlo-pf
approved these changes
Feb 11, 2026
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to_standard_orientation()to normalize the poloidal angle parametrization of stellarator-symmetricSurfaceRZFouriersurfaces so that theta=0 is on the outboard side and theta increases counterclockwise in an R-Z cross-section.evaluate_points_rzand_evaluate_dz_dthetato detect the current orientation, then applies Fourier coefficient transformations as needed.evaluate_points_xyz.from_pointsdocstring.Details
Five new functions added to
surface_rz_fourier.py:_is_theta_external_is_theta_counterclockwise_surface_shift_theta_by_pi_surface_change_theta_signto_standard_orientationTest plan
🤖 Generated with Claude Code