Skip to content

fix(USBSerial): bump per-line capture buffer 128 → 512 bytes #5307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
packerlschupfer wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −1
Open

fix(USBSerial): bump per-line capture buffer 128 → 512 bytes #5307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/Arduino_Core_Buddy/cores/arduino/USBSerial.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,16 @@ class USBSerial : public Stream {
private:
bool enabled;
bool isWriteOnly;
std::array<uint8_t, 128> lineBuffer;
// Per-line capture buffer fed by every char written to USB. Used by
// the lineBufferHook callback (e.g. WUI's /api/v1/log serial capture).
// 128 B was too small for several common Marlin lines: M115's
// FIRMWARE_NAME response is ~240 chars, full M503 settings dumps can
// exceed 200, and M118 user messages have no documented cap. Anything
// over the buffer was truncated to "..\n" in the hook output with no
// way for downstream tooling to recover the rest of the line.
// 512 B comfortably fits M115/M503/typical M118 with margin; the
// ".." truncation marker still triggers if a line happens to exceed.
std::array<uint8_t, 512> lineBuffer;
decltype(lineBuffer)::size_type lineBufferUsed;
static constexpr int32_t writeTimeoutUs = 3'000'000;

Expand Down