Fix a crash in Print settings selector dropdown - #15565
Open
lawik wants to merge 1 commit into
Open
Conversation
gdk_keyval_name() returns nullptr for a keyval it has no name for, which happens for key presses carrying an unmapped keycode. This triggered a crash under certain circumstances where KEY_UNKNOWN was sent as part of a dropdown being opened. Observed under KDE and XWayland. Reason for the keypresses still unclear. Either from KDE or Wayland. Fix is just guarding against the nullptr.
matteius
pushed a commit
to opensensor/PrusaSlicer
that referenced
this pull request
Aug 24, 2026
gdk_keyval_name() returns nullptr for a keyval it has no name for, which happens for key presses carrying an unmapped keycode. This triggered a crash under certain circumstances where KEY_UNKNOWN was sent as part of a dropdown being opened. Observed under KDE and XWayland. Reason for the keypresses still unclear. Either from KDE or Wayland. Fix is just guarding against the nullptr. Imported from upstream pull request prusa3d#15565 (cherry picked from commit 82dfd21)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gdk_keyval_name() returns nullptr for a keyval it has no name for, which happens for key presses carrying an unmapped keycode.
This triggered a crash under certain circumstances where KEY_UNKNOWN was sent as part of a dropdown being opened. Observed under KDE and XWayland. Reason for the keypresses still unclear. Either from KDE or Wayland.
Fix is just guarding against the nullptr.