Add support for Inner>Outer>Inner perimeter order - #15590
Open
Epsylon42 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests replaces the
external_perimeters_firstboolean option with aperimeters_orderenum and adds support forInner>Outer>Innerperimeter order, similar to one present in some other slicers.I also fixed an inconsistency between the Classic and Arachne perimeter generators. Previously brim would affect first layer perimeter order in the Classic but not in Arachne. Now it affects both, basically overriding this option for the first layer and always printing outside-in as a continuation of the brim. (To be honest i'm not sure if that's necessary, but I tried to preserve as much of previous behavior as possible)
SeamPlacer.cpp. The change seems trivial-ish and should not change behavior forInner>OuterandOuter>Innermodes. For theInner>Outer>Innermode I assumed that it should work the same asOuter>Inner. If someone can tell me how to test if this is correct (what to print and where to look) - I will.Closes #9393
Closes #14888
Possibly closes #8949
And possibly some other requests for the same feature