Fix clipped legacy emboss modifiers by refreshing convex hulls - #15829
Open
bunnybones1 wants to merge 1 commit into
Open
Fix clipped legacy emboss modifiers by refreshing convex hulls#15829bunnybones1 wants to merge 1 commit into
bunnybones1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing a PrusaSlicer 2.x project with embossed modifier volumes can drop parts of the text during slicing even though the complete mesh is present. In an affected 2.9.6 project, alpha11 prints only the upper loop of an “8”; all eight numbered tags lose their lower portions.
fix_volume_transformation()transforms the mesh and applies the inverse transform to the volume, preserving its position. The cached convex hull remains in the old local coordinates.PrintApply.cpp::update_volume_bboxes()then uses that stale hull to bound modifier regions and can exclude valid slices. Recalculate the hull after transforming the mesh.Includes a small synthetic legacy 3MF fixture with two cuboids and an emboss transform. The regression checks that the imported modifier's hull bounds match its mesh bounds; no font or printer preset is required.
Validation on macOS 26.6:
slic3r-app-cli-testssuite passes.The validation build used GMP 6.3.0 for a separately investigated Apple Silicon crash; that dependency change is not part of this PR. The failing/passing regression used the same dependency build.