Allow sorting query parameters #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism to sort query parameters for
CacheController.cache_url, so that even if the requests were issued without sorting them first, caching should still work.The code changes seem simple enough, but I didn't quite get the hang of the testing (and doc) style, so pruning and reworking are likely.
I've been seeing a lot of cache misses after wrapping PRAW and using FileCache. It turns out that it was passing parameters as dicts to requests, then on each script invocation the query parameters order was randomized. That means a > 95% chance of a false cache miss on second request for 4 parameters if I'm mathing it good.
Here's a simple script to illustrate the issue.