Fix request cookies set to None#7468
Closed
puneetdixit200 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2716.
Method-level cookies with
Nonevalues are meant to remove matching session cookies for that request. They were being converted into Cookie objects before the session merge, which could produce headers likefoo; baz=qux. This keeps dict cookie handling at the merge point soNonecan remove the inherited cookie while normal request-level cookie overrides still work.Tests run:
python -m pytest tests/test_requests.py::TestRequests::test_request_cookie_none_removes_session_cookie -qpython -m pytest tests/test_requests.py::TestRequests::test_request_cookie_none_removes_session_cookie tests/test_requests.py::TestRequests::test_request_cookie_overrides_session_cookie tests/test_requests.py::TestRequests::test_request_cookies_not_persisted tests/test_requests.py::TestRequests::test_param_cookiejar_works tests/test_requests.py::TestRequests::test_generic_cookiejar_works -qpython -m pytest tests/test_requests.py -k cookie -qpython -m ruff check src/requests/_types.py src/requests/cookies.py src/requests/sessions.py tests/test_requests.pypython -m ruff format --check src/requests/_types.py src/requests/cookies.py src/requests/sessions.py tests/test_requests.pypython -m pyright src/requests/git diff --check