bugfix: on macos libtoolize is called glibtoolize #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I find it hard to say if this works, since I'm not on MacOS, but the pipeline is working. Maybe someone else can do a test on their machine. Let me know when this is ready, though. I would merge this either way. |
|
I realized this because the build was failing on my MacOS. There are similar workarounds in https://github.com/pspdev/pspdev/blob/master/depends/check-dependencies.sh#L39 from where I took the idea. |
|
Appreciated, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build on macos is failing because libtoolize doesn't exist because is called glibtoolize