Skip to content

[DRAFT] Demo TinyViT compatibility with tiled Siracusa #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 39 commits into
base: devel
Choose a base branch
from
Draft

[DRAFT] Demo TinyViT compatibility with tiled Siracusa #124

wants to merge 39 commits into from

Conversation

diaconuccalin
Copy link
Contributor

Describe the intent of your PR here.

Added

  • Bias handling for regular and DW Conv2D tiling
  • Float non-requantized DW Conv2D tiling constraints
  • Broadcast support for MatMul tiling constraints
  • ReduceMean and Slice nodes tiling constraints and bindings

Changed

Fixed

  • Input cube computation for tiled DW Conv2D
  • GELU PULPOpen kernel, to match tanh approximation, as done on the generic platform

PR Merge Checklist

  1. The PR is rebased on the latest devel commit and pointing to devel.
  2. Your PR reviewed and approved.
  3. All checks are passing.
  4. The CHANGELOG.md file has been updated.
  5. If the docker was modified, change back its link after review.

@diaconuccalin
Conv2D Bias Adaptation
63675c6
@diaconuccalin
Adde PULPOpen support for Conv2D and partially working DW Conv2D. Fix…
549a052 
…ed closure naming issue
@diaconuccalin
DW 2D Float Conv for PULPOpen platform now working. Updated im2col bu…
b32a357 
…ffer size computation. Added fixes to remove warnings
@diaconuccalin
Optimized the PULPOpen DW 2D fp32 Convolution and fixed the bias vers…
340d058 
…ion. Adjusted memory allocation for the im2col buffer in 2d float conv for PULPOpen (lower requirement, dynamic allocation). Included all Float 2D Conv tests in the CI pipeline for siracusa
@diaconuccalin
Updated float reshape with skip connection test to a smaller one
00da44e
@diaconuccalin
Fixed generic platform alias_of bug
a7f0fc0
@diaconuccalin
Fixed the PULPOpen FloatGemmTemplate (identical issue to the generic …
10b22ae 
…version). Added MatMulAddMergePass to the PULP optimizer. Added float-reshape-skip-connection test to Siracusa CI pipeline. Fixes in the FloatAddTemplate of PULPOpen to eliminate warnings
@diaconuccalin
Working TinyViT Demo test. Added it to the CI pipeline. Added float s…
58a01ab 
…lice and reduce mean bindings for Siracusa.
@diaconuccalin
Added GEMM batched fix to MatMul template
77b055f
@diaconuccalin
Fixed formatting
3079743
@diaconuccalin
Fixes to avoid warnings
ff9a903
@diaconuccalin
Merge remote-tracking branch 'origin/devel' into TinyViT_Siracusa
ad13fe2
@diaconuccalin
Fix formatting
3a17aa4
@diaconuccalin
Merge fix
8f3f74d
@diaconuccalin
Dynamic buffer calculation fix. Other fixes
63f122d
@diaconuccalin
Reformat
f012b1a
@diaconuccalin
Added back CI tests removed by merge
de2752b
@diaconuccalin
Updated changelog file
11d5293
@diaconuccalin
Applied fixes suggested in the PR review
ce7e4c8
@diaconuccalin
Merge branch 'devel' into TinyViT_Siracusa
4165983 
Signed-off-by: Călin Diaconu <[email protected]>
@diaconuccalin
Post-merge fixes
af78d75
@diaconuccalin
Quickfix
bc2119e
@diaconuccalin
Included bias handling in tile constraint handling for conv 2D. Fix i…
2ae4359 
…n input cube size computation for conv 2D constraint. Other fixes to remove warnings
@diaconuccalin
Fixed input cube computation for 2D conv tiling
fa4d396
@diaconuccalin
Added tiling bias handling for regular Conv2D in PULPOpen
8f02b04
@diaconuccalin
Added core number information to the network container, for buffer al…
6d96399 
…location in im2col
@diaconuccalin
Added non-RQ FP DW Conv2D tiling-ready binding and constraints. Test …
6f617d1 
…runner fix. Format fixes
@diaconuccalin
Bias support for DW 2d Conv tiling. im2col buffer computation fix. co…
68f7d0c 
…mputeInputCube() backwards compatiblity fix
@diaconuccalin
Added broadcasting handling for MatMul tile constraint. Fixed formatting
3b16813
@diaconuccalin
Added prototypes for PULPOpen Slice and ReduceMean tiling constraints
70390c8
@diaconuccalin diaconuccalin self-assigned this Oct 16, 2025
@diaconuccalin diaconuccalin added Bug Something isn't working Feature labels Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Victor-Jung Victor-Jung Awaiting requested review from Victor-Jung Victor-Jung will be requested when the pull request is marked ready for review Victor-Jung is a code owner

@Xeratec Xeratec Awaiting requested review from Xeratec Xeratec will be requested when the pull request is marked ready for review Xeratec is a code owner

@lukamac lukamac Awaiting requested review from lukamac lukamac will be requested when the pull request is marked ready for review lukamac is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@diaconuccalin diaconuccalin

Labels

Bug Something isn't working Feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@diaconuccalin