-
Notifications
You must be signed in to change notification settings - Fork 80
Add Coremark. #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Coremark. #217
Conversation
This is a draft, but also ready for review. Is there a mistake here? If not, how should I interpret this? |
I left it as draft because I was considering adding a CI step that launches coremark on an FPGA as a proof that the test is successful and returns a consistent result. Do you think it would make sense? |
Dependent on the nonfree related PR |
@paulsc96 I think this one is ready for being reviewed. |
It looks fine overall, but I will have to think the details through. One important question is: is it feasible to avoid a fork of Coremark? If so, we should. If not, we may aswell move some of the coremark-specific build stuff there. |
I think avoiding the fork whould be feasible if we move some stuff here, in the end they are not many files... I can spend some time on this later this week |
3fe9230
to
11b2712
Compare
@paulsc96 this is complete now. |
This PR integrates the Coremark benchmark into Cheshire.
Task list:
CHS_XILINX_FLASH_BIN
intoCHS_XILINX_FLASH_IMG
(I have updated the source files but don't know how to properly change the doc website).Discussion points:
O2
compiler options instead ofO3
? This is just for curiosity since the performance increase on Coremark is negligible (0.01 Coremark/MHz).