id_queue: Simplify existence lookup for Verilator speed-up #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxWipfli
changed the title
MaxWipfli
force-pushed
the
id_queue_verilator
branch
from
6d41088 to
57e1306
Compare
niwis
requested changes
Jun 20, 2025
There was a problem hiding this comment.
Thank you @MaxWipfli, this is a great simplification! Just one request: could you consistently use the bit operators on the RHS? (~ instead of !, & instead of &&).
|
Thanks for the review, I fixed the operators as requested. |
niwis
approved these changes
Jun 20, 2025
Scheremo
pushed a commit
to mosaic-soc/common_cells
that referenced
this pull request
Sep 12, 2025
* id_queue: Simplify existence lookup for Verilator speed-up * id_queue: Use bit-wise instead of logical operators * id_queue: Fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
always_combblock previously consumed 9% of total simulation runtime for Cheshire on Verilator (pulp-platform/cheshire#230). With this change, this is reduced to a vanishing amount (reported as 0.00%).