-
Notifications
You must be signed in to change notification settings - Fork 7
sw: Add more complex Snitch application tests #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6e26ff8 to
b3e900a
Compare
55c0a44 to
56f5d38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a general comment, we may want to prefix all functions as we do with snrt_ in the Snitch runtime, perhaps with pb_. The primary advantage to me being that it communicates clearly where they are defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments I forgot to add before.
43cb5c5 to
42936ab
Compare
38adb2b to
99ac5d2
Compare
99ac5d2 to
2aa5ff5
Compare
7101db9 to
800a0d4
Compare
800a0d4 to
0d447e1
Compare
0d447e1 to
e5d4d2e
Compare
8f6361e to
0a87358
Compare
6d972c9 to
55aa6b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The snitch_cluster and common_cells bump look fine to me. I can remove the existing tapeout tag and recreate it once we merge this. I have some minor changes below.
16c469b to
6485ded
Compare
Contributions:
vsim-run-batch-verifygoal for apps with verification script (also in PD repo)