macOS build compatibility (readline and ioctl includes) #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds compatibility fixes for building the toolchain on macOS (tested on macOS and Ubuntu 22.04).
Changes introduced:
<sys/ioctl.h>,<stdio.h>) for macOS builds.ECHOCTLand other undefined symbols on Darwin.readlinesources to avoid C23 prototype warnings.Why it’s safe:
All additions are protected with
#ifdef __APPLE__, so Linux and other environments are not affected.Testing:
Please review and merge this PR before the main toolchain PR (
pulp-riscv-gnu-toolchain).