Skip to content

Implement pulsar-dev-container - #1395

Open
ottok wants to merge 1 commit into
pulsar-edit:masterfrom
ottok:feature/pulsar-dev-container
Open

ottok wants to merge 1 commit into
pulsar-edit:masterfrom
ottok:feature/pulsar-dev-container

Conversation

@ottok

@ottok ottok commented Dec 26, 2025

Copy link
Copy Markdown

Make it easier for new contributors to get up-and-running quickly by introducing a single script that builds a container with all required dependencies, and allows to easily run any yarn command in the project.

You can test this by running e.g.

./container/pulsar-dev-container.sh
./container/pulsar-dev-container.sh yarn start

Demo:

output.mp4

Make it easier for new contributors to get up-and-running quickly by
introducing a single script that builds a container with all required
dependencies, and allows to easily run any `yarn` command in the project.

Signed-off-by: Otto Kekäläinen <otto@kekalainen.net>
@savetheclocktower

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

I'm not a habitual Docker user, so I'm curious if another contributor (@DeeDeeG?) is willing to give more informed feedback on this than I can muster.

@DeeDeeG

DeeDeeG commented Dec 29, 2025

Copy link
Copy Markdown
Member

Thank you for taking the time to do all this!

I don't believe the currently active team members are using Docker much, and this would be fairly parallel to the CI definitions we do use. I think it's neat and would be happy to point people to this PR if they need a Docker setup to get started. But the likelihood of maintenance on our side feels low, so putting it in the core repo feels like a "wrong location" thing, IMO. (For bitrot concerns, and due to the lack of a code owner among the long-haul established team who can support and explain it well to potential newcomers).

Just one opinion and open to hearing other voices from core team and potential / current contributors.

@ottok

ottok commented Mar 12, 2026

Copy link
Copy Markdown
Author

I don't believe the currently active team members are using Docker much

You do have a Dockerfile (https://github.com/pulsar-edit/pulsar/blob/8da14949c75af2d0779f36acb44487075f56b6cb/Dockerfile) and you haven't removed or maintaned it.

As it is most likely not used by anyone, I could add a commit to this PR that deletes that file.

@DeeDeeG

DeeDeeG commented Mar 13, 2026

Copy link
Copy Markdown
Member

It is my personal hope that the existing Dockerfile is removed on master branch at some point. (I should probably PR that if I am the most opinionated about it.) Apologies for the delays / slow pace of things.

Update: I opened said PR: #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants