Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use provided.al2 AWS Go Lambda runtime to fix build process #1677

Conversation

Luke-Rogerson
Copy link
Contributor

What?

This PR updates this example to use the now required provided.al2 AWS Go Lambda runtime, along with necessary related changes.

Why?

Running pulumi up in this example results in the following error:

InvalidParameterValueException: The runtime parameter of go1.x is no longer supported for creating or updating AWS Lambda functions. 
We recommend you use a supported runtime while creating or updating functions.

go1.x runtime Lambdas must now be migrated to provided.al2023 or provided.al2 runtimes.

Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

@Luke-Rogerson
Copy link
Contributor Author

Bump! 😃

@Luke-Rogerson
Copy link
Contributor Author

Anyone?!

@Luke-Rogerson
Copy link
Contributor Author

Can I get a review?

Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

@rshade
Copy link
Contributor

rshade commented Jan 9, 2025

can you rebase real quick and I will /run-example-tests?

@rshade rshade self-requested a review January 9, 2025 15:10
@Luke-Rogerson Luke-Rogerson force-pushed the go-aws-example-update branch from b1a7cd9 to bbf343e Compare January 9, 2025 20:42
Copy link

github-actions bot commented Jan 9, 2025

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

@Luke-Rogerson
Copy link
Contributor Author

can you rebase real quick and I will /run-example-tests?

Thank you, sir. I have rebased.

@Luke-Rogerson Luke-Rogerson reopened this Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

1 similar comment
Copy link

github-actions bot commented Jan 9, 2025

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

Copy link
Contributor

@rshade rshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for you contribution. These look good to me. Once the tests run I will merge.

@rshade rshade enabled auto-merge (squash) January 9, 2025 21:17
@Luke-Rogerson
Copy link
Contributor Author

Thank you for you contribution. These look good to me. Once the tests run I will merge.

Great! Seems some issue loading AWS credentials in the tests btw

@rshade
Copy link
Contributor

rshade commented Jan 10, 2025

/run-example-tests

@rshade rshade changed the base branch from master to Luke-Rogerson-go-aws-example-update January 10, 2025 13:00
@rshade
Copy link
Contributor

rshade commented Jan 10, 2025

@Luke-Rogerson looks like I am going to have to pull you into a local branch to run it.

@rshade rshade merged commit 0f4586c into pulumi:Luke-Rogerson-go-aws-example-update Jan 10, 2025
4 of 80 checks passed
rshade added a commit that referenced this pull request Jan 14, 2025
…reated for Tests to run) #1770 (#1771)

## What?

This PR updates this example to use the now required `provided.al2` AWS
Go Lambda runtime, along with necessary related changes.

## Why?

Running `pulumi up` in this example results in the following error:

```
InvalidParameterValueException: The runtime parameter of go1.x is no longer supported for creating or updating AWS Lambda functions. 
We recommend you use a supported runtime while creating or updating functions.
```

`go1.x` runtime Lambdas [must now be

migrated](https://docs.aws.amazon.com/lambda/latest/dg/lambda-golang.html#golang-al1)
to `provided.al2023` or `provided.al2` runtimes.

Co-authored-by: Luke Rogerson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants