-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use provided.al2
AWS Go Lambda runtime to fix build process
#1677
Use provided.al2
AWS Go Lambda runtime to fix build process
#1677
Conversation
PR is now waiting for a maintainer to run the acceptance tests. |
Bump! 😃 |
Anyone?! |
Can I get a review? |
PR is now waiting for a maintainer to run the acceptance tests. |
can you rebase real quick and I will |
b1a7cd9
to
bbf343e
Compare
PR is now waiting for a maintainer to run the acceptance tests. |
Thank you, sir. I have rebased. |
PR is now waiting for a maintainer to run the acceptance tests. |
1 similar comment
PR is now waiting for a maintainer to run the acceptance tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for you contribution. These look good to me. Once the tests run I will merge.
Great! Seems some issue loading AWS credentials in the tests btw |
/run-example-tests |
@Luke-Rogerson looks like I am going to have to pull you into a local branch to run it. |
0f4586c
into
pulumi:Luke-Rogerson-go-aws-example-update
…reated for Tests to run) #1770 (#1771) ## What? This PR updates this example to use the now required `provided.al2` AWS Go Lambda runtime, along with necessary related changes. ## Why? Running `pulumi up` in this example results in the following error: ``` InvalidParameterValueException: The runtime parameter of go1.x is no longer supported for creating or updating AWS Lambda functions. We recommend you use a supported runtime while creating or updating functions. ``` `go1.x` runtime Lambdas [must now be migrated](https://docs.aws.amazon.com/lambda/latest/dg/lambda-golang.html#golang-al1) to `provided.al2023` or `provided.al2` runtimes. Co-authored-by: Luke Rogerson <[email protected]>
What?
This PR updates this example to use the now required
provided.al2
AWS Go Lambda runtime, along with necessary related changes.Why?
Running
pulumi up
in this example results in the following error:go1.x
runtime Lambdas must now be migrated toprovided.al2023
orprovided.al2
runtimes.