Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to fix DockerBuild Settings, Fixes #1869 #2056

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

rshade
Copy link
Contributor

@rshade rshade commented Feb 26, 2025

No description provided.

@rshade rshade force-pushed the update-docker-build branch from 69acb41 to 01c570d Compare February 27, 2025 02:33
@rshade rshade enabled auto-merge (squash) February 27, 2025 14:35
@rshade rshade requested a review from Copilot March 5, 2025 16:17

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates Docker build settings for the Azure app service and AWS voting app by switching to new Pulumi DockerBuild APIs.

Reviewed Changes

File Description
azure-cs-appservice-docker/MyStack.cs Refactored Docker build configuration and adjusted registry parameters using Pulumi DockerBuild types.
aws-py-voting-app/main.py Updated Docker build integration for the Flask image and modified registry info retrieval to align with the new DockerBuild API.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

azure-cs-appservice-docker/MyStack.cs:79

  • [nitpick] The variable name 'myImage' is used to represent a Docker image built via the DockerBuild API; consider renaming it (e.g., 'builtImage') for clarity and consistency across the codebase.
var myImage = new DockerBuild.Image(customImage, new Pulumi.DockerBuild.ImageArgs

aws-py-voting-app/main.py:274

  • [nitpick] The variable name 'flask_image_dockerbuild' is verbose and inconsistent with the typical naming convention; consider renaming it to 'flaskImage' or 'flaskDockerImage' for improved readability.
flask_image_dockerbuild = docker_build.Image(

aws-py-voting-app/main.py:308

  • Ensure that using 'pulumi.Output.concat' with a single string conversion is necessary; if 'redis_endpoint["port"]' is already an output, a direct conversion might be more straightforward.
"value": pulumi.Output.concat(str(redis_endpoint["port"])),
@rshade rshade force-pushed the update-docker-build branch 2 times, most recently from 4f3c4d2 to 4d4e5cc Compare March 5, 2025 21:28
@rshade rshade force-pushed the update-docker-build branch from 4d4e5cc to d5cc019 Compare March 5, 2025 22:33
Copy link
Member

@nelsonfigueroa nelsonfigueroa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rshade rshade merged commit dc0246a into master Mar 5, 2025
41 checks passed
@rshade rshade deleted the update-docker-build branch March 5, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants