helm: login to private registries #3661
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3661 +/- ##
==========================================
- Coverage 42.36% 42.26% -0.11%
==========================================
Files 87 88 +1
Lines 12669 12709 +40
==========================================
+ Hits 5367 5371 +4
- Misses 6907 6944 +37
+ Partials 395 394 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EronWright
reviewed
Jun 6, 2025
There was a problem hiding this comment.
For discussion:
- is this change affecting Release or Chart or both?
- does it have the same side-effect that helm install would normally?
- tool.go seems to be drifting away from the upstream, e.g. refactored tls. how close can we stick to upstream?
- is this affecting oci registries or also helm registries?
| // Login can fail for harmless reasons like already being | ||
| // logged in. Optimistically ignore those errors. | ||
| if err := c.Login(u.Host, registry.LoginOptBasicAuth(i.Username, i.Password)); err != nil { | ||
| logger.V(6).Infof("[helm] %s", fmt.Sprintf("login error: %s", err)) |
There was a problem hiding this comment.
nit: use a lower verbosity for this important message.
Also, consider writing a log message when login was successful, maybe mentioning that the user's environment was modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #3314.
The bulk of the new work went into crafting a failing test case. In short it:
Testing revealed that setting
registry.ClientOptBasicAuth(username, password)on the client is insufficient. This sorta makes sense to me -- Helm doesn't want to blindly pass that username and password to any registry the client might interact with.The solution I came up with isn't super satisfying but essentially performs the
helm loginwe're currently asking users to perform manually. This can fail for a number of reasons, for example if we're already logged in, so we optimistically ignore errors here.Chart v4 and Release v3 are both confirmed to be working. The Release provider's client setup is awkwardly separate from our Chart handling (Chart being more correct), but consolidating those two flows is a separate work item.
Fixes #2911.
Fixes #1914.