Skip to content

Query gid to prevent errors with missing users with the same id (fixes #1229) #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

cmusik
Copy link
Contributor

@cmusik cmusik commented Dec 20, 2024

Summary

If a firewall rule is assigned to a group and the same user does not exist, then we get an error:

Error: /Stage[main]/Main/Firewall[801 - gid testgroup]/gid: change from '1234' to 'testgroup' failed: can't find user for testgroup

This is a fix for #1229.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@cmusik cmusik requested a review from a team as a code owner December 20, 2024 11:03
@amitkarsale
Copy link
Contributor

@cmusik, Thanks for the PR, can you please check for the test failures.

@cmusik
Copy link
Contributor Author

cmusik commented Apr 10, 2025

I have checked the logs, but the errors are during puppet agent setup phase. I think that we have an infrastructure problem here and I can't do anything about it.

Copy link
Contributor

@span786 span786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures are not related to the change, therefore approving it.

@span786 span786 merged commit d4a6643 into puppetlabs:main Apr 15, 2025
30 of 50 checks passed
@span786 span786 added the bugfix label Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants